Fix lint errors

experimental/libbox/internal/oomprofile/builder.go

@@ -374,10 +374,6 @@ func (b *profileBuilder) emitLocation() uint64 {
 	return id
 }
 
-func (b *profileBuilder) addMapping(lo uint64, hi uint64, offset uint64, file string, buildID string) {
-	b.addMappingEntry(lo, hi, offset, file, buildID, false)
-}
-
 func (b *profileBuilder) addMappingEntry(lo uint64, hi uint64, offset uint64, file string, buildID string, fake bool) {
 	b.mem = append(b.mem, memMap{
 		start:   uintptr(lo),

experimental/libbox/internal/oomprofile/mapping_darwin.go

@@ -14,7 +14,10 @@ func isExecutable(protection int32) bool {
 }
 
 func (b *profileBuilder) readMapping() {
-	if !machVMInfo(b.addMapping) {
+	added := machVMInfo(func(lo, hi, offset uint64, file, buildID string) {
+		b.addMappingEntry(lo, hi, offset, file, buildID, false)
+	})
+	if !added {
 		b.addMappingEntry(0, 0, 0, "", "", true)
 	}
 }

experimental/libbox/internal/oomprofile/mapping_linux.go

@@ -6,7 +6,9 @@ import "os"
 
 func (b *profileBuilder) readMapping() {
 	data, _ := os.ReadFile("/proc/self/maps")
-	stdParseProcSelfMaps(data, b.addMapping)
+	stdParseProcSelfMaps(data, func(lo, hi, offset uint64, file, buildID string) {
+		b.addMappingEntry(lo, hi, offset, file, buildID, false)
+	})
 	if len(b.mem) == 0 {
 		b.addMappingEntry(0, 0, 0, "", "", true)
 	}

experimental/libbox/internal/oomprofile/oomprofile.go

@@ -320,7 +320,7 @@ func writeHeapProto(w io.Writer, profile []memProfileRecord, rate int64, default
 	var locs []uint64
 	for _, record := range profile {
 		hideRuntime := true
-		for tries := 0; tries < 2; tries++ {
+		for range 2 {
 			stk := record.Stack
 			if hideRuntime {
 				for i, addr := range stk {

experimental/libbox/neighbor.go

@@ -1,10 +1,5 @@
 package libbox
 
-import (
-	"net"
-	"net/netip"
-)
-
 type NeighborEntry struct {
 	Address    string
 	MacAddress string
@@ -23,31 +18,3 @@ type NeighborSubscription struct {
 func (s *NeighborSubscription) Close() {
 	close(s.done)
 }
-
-func tableToIterator(table map[netip.Addr]net.HardwareAddr) NeighborEntryIterator {
-	entries := make([]*NeighborEntry, 0, len(table))
-	for address, mac := range table {
-		entries = append(entries, &NeighborEntry{
-			Address:    address.String(),
-			MacAddress: mac.String(),
-		})
-	}
-	return &neighborEntryIterator{entries}
-}
-
-type neighborEntryIterator struct {
-	entries []*NeighborEntry
-}
-
-func (i *neighborEntryIterator) HasNext() bool {
-	return len(i.entries) > 0
-}
-
-func (i *neighborEntryIterator) Next() *NeighborEntry {
-	if len(i.entries) == 0 {
-		return nil
-	}
-	entry := i.entries[0]
-	i.entries = i.entries[1:]
-	return entry
-}

experimental/libbox/neighbor_unix.go

@@ -0,0 +1,36 @@
+//go:build linux || darwin
+
+package libbox
+
+import (
+	"net"
+	"net/netip"
+)
+
+func tableToIterator(table map[netip.Addr]net.HardwareAddr) NeighborEntryIterator {
+	entries := make([]*NeighborEntry, 0, len(table))
+	for address, mac := range table {
+		entries = append(entries, &NeighborEntry{
+			Address:    address.String(),
+			MacAddress: mac.String(),
+		})
+	}
+	return &neighborEntryIterator{entries}
+}
+
+type neighborEntryIterator struct {
+	entries []*NeighborEntry
+}
+
+func (i *neighborEntryIterator) HasNext() bool {
+	return len(i.entries) > 0
+}
+
+func (i *neighborEntryIterator) Next() *NeighborEntry {
+	if len(i.entries) == 0 {
+		return nil
+	}
+	entry := i.entries[0]
+	i.entries = i.entries[1:]
+	return entry
+}