wangjia
68608d6471
ci-pangolin / Lint — shellcheck (pull_request) Successful in 13s
ci-pangolin / Redline Scan — 脱敏 (UI 文案) (pull_request) Successful in 24s
ci-pangolin / Cleartext Scan — Android 禁明文 (pull_request) Successful in 20s
ci-pangolin / OpenAPI Sync Check (pull_request) Successful in 34s
ci-pangolin / Portable SQL — 可移植性 (mysql/sqlite) (pull_request) Successful in 22s
ci-pangolin / Flutter — analyze + test (pull_request) Successful in 36s
ci-pangolin / Codegen Drift — token 生成物未漂移 (pull_request) Successful in 3s
ci-pangolin / DS-flow — 原型/跨端同源/代码色单源闸 (pull_request) Successful in 4s
ci-pangolin / Go — build + test (pull_request) Failing after 13s
ci-pangolin / E2E Smoke — L4 进程级端到端 (pull_request) Failing after 11s
ci-pangolin / Go — integration (mysql/redis testcontainers) (pull_request) Failing after 4m37s
ci-pangolin / Golden — 视觉回归 (全量:components/auth/desktop/tablet) (pull_request) Failing after 19s
CreateUserWithTrial 新增本地 Noticer 接口(同 InsertNoticeTx 签名,参照 reward 包做法避免 notices→auth 循环依赖);SQLStore 加 noticer 字段 + SetNoticer, nil-safe。注册事务插完 trial 订阅、commit 前,若已注入 noticer 则同事务插一条 type=reward 的双语欢迎通知(标题/正文按 trialDays 参数化),失败即整事务回滚, 与 reward/pay 到账钩子同语义、零孤儿。main.go 在 noticesStore 构造后装配 authStore.SetNoticer(noticesStore)(authStore 提升到 if-block 外声明以跨块可见)。 顺带修复 isDuplicateKey 只认 MySQL 错误文案的 dialect 缺口——sqlite 下重复邮箱 注册此前会落入错误分支返回不透明的「auth: insert user」,而非 ErrEmailTaken; 现同时匹配 sqlite 的 "UNIQUE constraint failed"。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P9G7E3wmAYL9KeYCVZVsqu
106 lines
3.4 KiB
Go
106 lines
3.4 KiB
Go
package auth
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/wangjia/pangolin/server/internal/config"
|
|
"github.com/wangjia/pangolin/server/internal/store"
|
|
)
|
|
|
|
// openAuthDB spins up an in-memory sqlite DB with the full migration set
|
|
// (plans get seeded by 000007_seed.up.sql), mirroring reward package's
|
|
// openDB test harness. Exported (capitalized) so the external store_notices_test.go
|
|
// (package auth_test, needed to avoid the notices->auth import cycle) can reuse it.
|
|
func OpenAuthDBForTest(t *testing.T) *sql.DB {
|
|
t.Helper()
|
|
db, err := store.Open(&config.Config{Driver: "sqlite", DSN: ":memory:"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
t.Cleanup(func() { _ = db.Close() })
|
|
if err := store.MigrateUp(db, "sqlite"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := store.ApplyCodesLibMigrations(context.Background(), db, "sqlite"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return db
|
|
}
|
|
|
|
// fakeNoticer 记录调用,用于验证「未设置 noticer 时跳过」与「显式 fake 校验参数」两种路径。
|
|
// 用 fake(而非真实 notices.Store)是因为 notices 包反向 import auth(handler.go 用
|
|
// auth.UserIDFromContext),同包内部测试(package auth)若再 import notices 会成环;
|
|
// 真实 notices.Store 的集成断言放到外部测试包 store_notices_test.go(package auth_test)。
|
|
type fakeNoticer struct {
|
|
calls int
|
|
last struct {
|
|
userID int64
|
|
typ, titleZH, titleEN string
|
|
bodyZH, bodyEN, link string
|
|
}
|
|
}
|
|
|
|
func (f *fakeNoticer) InsertNoticeTx(_ context.Context, _ *sql.Tx, userID int64, typ, titleZH, titleEN, bodyZH, bodyEN, link string, _ time.Time) error {
|
|
f.calls++
|
|
f.last.userID = userID
|
|
f.last.typ = typ
|
|
f.last.titleZH = titleZH
|
|
f.last.titleEN = titleEN
|
|
f.last.bodyZH = bodyZH
|
|
f.last.bodyEN = bodyEN
|
|
f.last.link = link
|
|
return nil
|
|
}
|
|
|
|
// TestCreateUserWithTrial_NilNoticer_Skips: 未注入 noticer(装配前/未调用 SetNoticer)时,
|
|
// 注册仍应成功且不 panic —— 保持既有装配可编译、零副作用。
|
|
func TestCreateUserWithTrial_NilNoticer_Skips(t *testing.T) {
|
|
db := OpenAuthDBForTest(t)
|
|
s := NewSQLStore(db) // 不调用 SetNoticer
|
|
|
|
if _, err := s.CreateUserWithTrial(context.Background(), "nonoticer@example.com", "hash", 7); err != nil {
|
|
t.Fatalf("CreateUserWithTrial: %v", err)
|
|
}
|
|
var n int
|
|
if err := db.QueryRow(`SELECT COUNT(*) FROM notices`).Scan(&n); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if n != 0 {
|
|
t.Fatalf("notices count = %d, want 0 when noticer not set", n)
|
|
}
|
|
}
|
|
|
|
// TestCreateUserWithTrial_FakeNoticer_CalledOnceWithArgs: 用 fake 断言被调用一次、
|
|
// 参数与实际 trialDays 一致。
|
|
func TestCreateUserWithTrial_FakeNoticer_CalledOnceWithArgs(t *testing.T) {
|
|
db := OpenAuthDBForTest(t)
|
|
s := NewSQLStore(db)
|
|
fn := &fakeNoticer{}
|
|
s.SetNoticer(fn)
|
|
|
|
u, err := s.CreateUserWithTrial(context.Background(), "fake@example.com", "hash", 14)
|
|
if err != nil {
|
|
t.Fatalf("CreateUserWithTrial: %v", err)
|
|
}
|
|
if fn.calls != 1 {
|
|
t.Fatalf("noticer calls = %d, want 1", fn.calls)
|
|
}
|
|
if fn.last.userID != u.ID {
|
|
t.Fatalf("noticer userID = %d, want %d", fn.last.userID, u.ID)
|
|
}
|
|
if fn.last.typ != "reward" {
|
|
t.Fatalf("noticer typ = %q, want reward", fn.last.typ)
|
|
}
|
|
wantBodyZH := fmt.Sprintf("已为你开通 %d 天 PRO 会员,现在就选节点连接,畅享全球网络。", 14)
|
|
if fn.last.bodyZH != wantBodyZH {
|
|
t.Fatalf("noticer bodyZH = %q, want %q", fn.last.bodyZH, wantBodyZH)
|
|
}
|
|
if fn.last.link != "" {
|
|
t.Fatalf("noticer link = %q, want empty", fn.last.link)
|
|
}
|
|
}
|